chore: plugin compatibility infos #966
Conversation
|
I wouldnt enforce it for the moment, maybe a warning in the admin or in the logs? |
|
No enforcing, will make things way more complicated |
core/cat/mad_hatter/plugin.py
Outdated
| # Core compatibility | ||
| compatibility = json_file_data.get( | ||
| "compatibility", | ||
| { |
There was a problem hiding this comment.
Please keep the structure flat for the moment, maybe with a more explicit naming, i.e.
version, ..., min_cat_version, max_cat_version
core/cat/mad_hatter/plugin.py
Outdated
| "compatibility", | ||
| { | ||
| "min_version": "not specified", | ||
| "max_version": "not specified", |
There was a problem hiding this comment.
maybe empty string as default value, we made a mess in the past with a different default for every key XD
There was a problem hiding this comment.
agree, also easier to handle in admin-vue
|
Here is admin-vue PR About an eventual warning we could:
|
Thanks @alfredotoselli, just merged. Let's see what the contribs think about the strategy here. |
Description
Added min and max version on plugin manifest.
If we agree on the structure I'll update admin-vue and ts-client (Plugin.ts type)
We want to enforce it? e.g. on plugin installation or activation (Not necessary for me)
Related to issue #960
Type of change
Checklist: